Joey
11/18/2021, 9:06 PMresource -> organization -> platform
Joey
11/18/2021, 9:06 PMJoey
11/18/2021, 9:07 PMbryana
11/18/2021, 9:08 PMsite
which seems like what you are suggesting for system
or platform
Joey
11/18/2021, 9:08 PMbryana
11/18/2021, 9:09 PMorganization
intermediaryJoey
11/18/2021, 9:09 PMJoey
11/18/2021, 9:10 PMresource:someresource#viewer@user:*
Joey
11/18/2021, 9:10 PMresource:*#viewer@user:staffgal
Joey
11/18/2021, 9:10 PMJoey
11/18/2021, 9:10 PMbryana
11/18/2021, 9:10 PMbryana
11/18/2021, 9:11 PMJoey
11/18/2021, 9:12 PMrelation
I'd wager), then it would only affect performance minimallyJoey
11/18/2021, 9:12 PMcheck
)Joey
11/18/2021, 9:14 PMbryana
11/18/2021, 9:14 PMuser
11/18/2021, 9:15 PMbryana
11/18/2021, 9:23 PMJoey
11/18/2021, 9:33 PMbryana
11/18/2021, 10:51 PMJoey
11/18/2021, 10:51 PMRobin
11/19/2021, 6:34 PM@robinbraemer
and just want to make sure that the SpiceDB devs ( @User @User ) are aware of it...
While I read through your watch crdb code https://github.com/authzed/spicedb/blob/a75cd6484c313c71dfd98072dadf0a4fffaed4d0/internal/datastore/crdb/watch.go#L29 and the crdb docs https://www.cockroachlabs.com/docs/v21.2/changefeed-for#considerations It is therefore critical that you close the connection, otherwise the application will be blocked forever on Rows.Close().
- Since you use a pgx.Pool underneath, are you sure that the connection gets closed after the context to Watch stops watching, and that the pg connect is not just released back into the pool leaving the connection in an unusable state for new normal SQL queries?ecordell
11/19/2021, 7:07 PMwatch
code, I agree with your assessment that we're missing some important connection handling for changefeeds. I don't recall having seen any of the errors the crdb docs warn about, but maybe we've just been getting luckyecordell
11/19/2021, 7:07 PMRobin
11/20/2021, 3:55 PMuser
11/20/2021, 4:34 PMtoby357
11/22/2021, 2:51 AMtoby357
11/22/2021, 2:51 AMtoby357
11/22/2021, 2:52 AM