Problem running go mod tidy using grpcutil and google.golang.org/grpc 1.55.0
d
dguhr-rh
05/09/2023, 8:45 AMSo, dependabot just wanted us to bump
google.golang.org/grpchttps://cdn.discordapp.com/attachments/844600078948630559/1105415355196776539/Screenshot_2023-05-09_at_10.09.49.png▾
sidenote: looking at https://github.com/authzed/grpcutil/pulls it seems it needs a bit of love 😉
going back to 1.54.0 is a workaround
"a little love" fixed: https://github.com/authzed/grpcutil/pull/42
this does not solve the actual problem, but at least is not using heavily outdated versions anymore, and the linter gets green again 😉
https://github.com/grpc/grpc-go/issues/6264 fyi - seems the package is simply not included in the latest module release, package is at 1.54.1
@vroldanbet thx for the review. Installing and running gofumpt v0.5.0 takes kinda forever here, could you provide me the binary & command you folks use? (assuming I'm doing it wrong)
v
vroldanbet
05/09/2023, 10:56 AMI assume you mean the command we use to run the lint locally? I usually use
golanci-lintI can fix the linter issue for you if you want
d
dguhr-rh
05/09/2023, 11:00 AMsure, feel free 🙂
I also use golangci-lint run --fix usually, maybe that does it
v
vroldanbet
05/09/2023, 11:01 AMdone, pushed the changes
d
dguhr-rh
05/09/2023, 11:02 AMok, nvm 🙂 perhaps I just forgot to run the linter one last time with --fix
and thanks!
v
vroldanbet
05/09/2023, 11:02 AMI'm afraid we are going to have to wait before merging this - I think the CLA build is borked, should have prompted you to confirm CLA
let me see if I can land jimmy's PR
unless you already signed at some point and that's why you don't get asked?
d
dguhr-rh
05/09/2023, 11:03 AMyeh, there are open PRs to update the gha for CLA and setup-go also
didn't touch these
maybe merge them first, then re-open the PR would do the trick
I already signed, but not on grpcutil, on authzed-go
no idea tbh if that suffices
v
vroldanbet
05/09/2023, 11:04 AMd
dguhr-rh
05/09/2023, 11:04 AMah ok, so its enough to sign in one of the repos?
v
vroldanbet
05/09/2023, 11:04 AMyeah, right, that's the bit that is not clear to me, if we need a signature per repo. @jzelinskie ?
d
dguhr-rh
05/09/2023, 11:05 AMgood to know. (do I get a washing machine now? 😉 )
v
vroldanbet
05/09/2023, 11:37 AMit should be mostly done, but GitHub has problems with git right now so I can't push last fixes and merge
https://github.com/authzed/grpcutil/pull/15
j
jzelinskie
05/09/2023, 2:42 PMnope it's one signature for all contributions
d
dguhr-rh
05/09/2023, 3:06 PMcool, then I guess nothing holds us back from merging the version /linter updates. The real problem is still valid btw, thus we stick with v1.54.0 now for google.golang.org/grpc, but that's on them to solve I guess (see https://github.com/grpc/grpc-go/issues/6264 )
v
vroldanbet
05/09/2023, 3:46 PMno, sorry, I couldn't merge it before because GitHub down
should be all merged now
d
dguhr-rh
05/09/2023, 7:09 PM@vroldanbet @jzelinskie fyi: https://github.com/grpc/grpc-go/issues/6264 they answered, but it's not just exchanging the package nor recommended to update to 1.55 using the test protos from - now - interop/grpc_testing.
If you verify to me that the check for the payloadtype here: https://github.com/authzed/grpcutil/blob/main/middleware_test.go#L288-L289 is not important and might be deleted, I'm happy to provide a PR for now to use
interop/grpc_testinggoogle.golang.org/grpc v1.55.0https://github.com/authzed/grpcutil/pull/47 PR. feel free to close if you have time and an idea on how to better solve it 😉
v
vroldanbet
05/09/2023, 7:42 PMcool, let's leave it at 1.54.0 for now, do you mind opening an issue capturing the problematic?
d
dguhr-rh
05/09/2023, 7:43 PMsure, np.
https://github.com/authzed/grpcutil/issues/48 Issue + https://github.com/DGuhr/go_grpcutil_repro minimal reproducer