https://authzed.com logo
Join Discord
Powered by
So, dependabot just wanted us to bump `google.gola...
# spicedb
d
So, dependabot just wanted us to bump 
google.golang.org/grpc
to 1.55.0 which I did, but now for some reason go mod tidy complains. See screenshot. Any idea? Seems to be sth the grpcutil uses
sidenote: looking at https://github.com/authzed/grpcutil/pulls it seems it needs a bit of love 😉
going back to 1.54.0 is a workaround
this does not solve the actual problem, but at least is not using heavily outdated versions anymore, and the linter gets green again 😉
https://github.com/grpc/grpc-go/issues/6264 fyi - seems the package is simply not included in the latest module release, package is at 1.54.1
@vroldanbet thx for the review. Installing and running gofumpt v0.5.0 takes kinda forever here, could you provide me the binary & command you folks use? (assuming I'm doing it wrong)
v
I assume you mean the command we use to run the lint locally? I usually use 
golanci-lint
instead
I can fix the linter issue for you if you want
d
sure, feel free 🙂
I also use golangci-lint run --fix usually, maybe that does it
v
done, pushed the changes
d
ok, nvm 🙂 perhaps I just forgot to run the linter one last time with --fix
and thanks!
v
I'm afraid we are going to have to wait before merging this - I think the CLA build is borked, should have prompted you to confirm CLA
let me see if I can land jimmy's PR
unless you already signed at some point and that's why you don't get asked?
d
yeh, there are open PRs to update the gha for CLA and setup-go also
didn't touch these
maybe merge them first, then re-open the PR would do the trick
I already signed, but not on grpcutil, on authzed-go
no idea tbh if that suffices
v
d
ah ok, so its enough to sign in one of the repos?
v
yeah, right, that's the bit that is not clear to me, if we need a signature per repo. @jzelinskie ?
d
good to know. (do I get a washing machine now? 😉 )
v
it should be mostly done, but GitHub has problems with git right now so I can't push last fixes and merge https://github.com/authzed/grpcutil/pull/15
j
nope it's one signature for all contributions
d
cool, then I guess nothing holds us back from merging the version /linter updates. The real problem is still valid btw, thus we stick with v1.54.0 now for google.golang.org/grpc, but that's on them to solve I guess (see https://github.com/grpc/grpc-go/issues/6264 )
v
no, sorry, I couldn't merge it before because GitHub down
should be all merged now
d
@vroldanbet @jzelinskie fyi: https://github.com/grpc/grpc-go/issues/6264 they answered, but it's not just exchanging the package nor recommended to update to 1.55 using the test protos from - now - interop/grpc_testing.
If you verify to me that the check for the payloadtype here: https://github.com/authzed/grpcutil/blob/main/middleware_test.go#L288-L289 is not important and might be deleted, I'm happy to provide a PR for now to use 
interop/grpc_testing
instead, and leave it to you to go the recommended way in the future. That way we and others using grpcutil would be unblocked from updating our service to 
google.golang.org/grpc v1.55.0
😉
https://github.com/authzed/grpcutil/pull/47 PR. feel free to close if you have time and an idea on how to better solve it 😉
v
cool, let's leave it at 1.54.0 for now, do you mind opening an issue capturing the problematic?
d
sure, np.
2 Views
PreviousNext
Powered by