Hi, I think I've found a bug. It's not
# spicedbd
d.richardson
11/02/2023, 5:01 PMHi, I think I've found a bug. It's not directly with one of the open source products, so I didn't make a bug in github, but I'm glad to do that. I have a workaround as well, so it's not super critical.
invalid expression for caveat `unexpired_grant`: ERROR: unexpired_grant👎0: expression code point size exceeds limit: size: 100306, limit 100000
See https://play.authzed.com/s/_zPjtwifESOy/schema. The workaround is to move the caveat to the top of the file, see https://play.authzed.com/s/NBlMsgoakVic/assertions.
d.richardson
11/02/2023, 5:02 PMObviously this example is contrived, I have a large schema and didn't want to share all the internal details 🙂
d.richardson
11/02/2023, 5:05 PMOh, and the place I see the error is the playground (hopefully clear from the links, but just in case...)
e
ecordell
11/02/2023, 7:37 PMNice find! I think this is worth a writeup in Github if you have the time (if not, let me know and I'll write it up)
Looks like some problem with how source locations are mapped into the CEL parser for caveats.
j
Joey
11/02/2023, 8:29 PMits because comments are attached to the first definition or caveat below them
Joey
11/02/2023, 8:29 PMso in your former example, you have the giant
//////Joey
11/02/2023, 8:29 PMin the latter, it attaches to the definition
Joey
11/02/2023, 8:29 PMand definitions can be larger
Joey
11/02/2023, 8:29 PMif I may ask: why the giant comment>?
d
d.richardson
11/03/2023, 5:27 PM@Joey the comment isn't really super special, in my private version, it's a bunch of very large definitions. But I didn't want to publicly share them, so I replaced it with a comment. Here's a version without any comments that replicates the issue https://play.authzed.com/s/AebNlkloDCyD/schema
j
Joey
11/03/2023, 5:28 PMthanks
Joey
11/03/2023, 5:28 PMwill take a look; can I use that ^ schema for testing?
Joey
11/03/2023, 5:28 PMi.e. add it into unit tests
Joey
11/03/2023, 5:45 PM@d.richardson ^
d
d.richardson
11/03/2023, 5:45 PMSorry, in a meeting, I'll get back to you soon
d.richardson
11/03/2023, 6:04 PMThanks for your patience. Sorry about that. Obviously most of what is there is randomly generated. I'd prefer my name doesn't end up in the unit tests though, and I'll rename iam_role_name to something even more generic just in case. This is totally fine to use in the unit tests https://play.authzed.com/s/b1-RN001EQpW/schema
d.richardson
11/03/2023, 6:09 PMj
Joey
11/03/2023, 6:10 PMsounds good
Joey
11/03/2023, 6:31 PMfigured it out; PR coming in
Joey
11/03/2023, 6:35 PMd
d.richardson
11/03/2023, 6:44 PMThanks @Joey that was fast, that fixes it on my real schema as well!
j
Joey
11/03/2023, 6:48 PMcool
Joey
11/03/2023, 6:48 PMwill be in the next release candidate