that s a good question SpiceDB #spicedb

Join Discord

that's a good question...

# spicedb

Joey

02/15/2023, 12:31 AM

that's a good question...

yetitwo

02/15/2023, 4:05 PM

my sense is that it's got something to do with

java_multiple_files = true

, which I wouldn't mind seeing because the

OuterClass

stuff is deeply unintuitive as a user. the only downside is that it'd be a breaking change to the

authzed-java

library.

yetitwo

02/15/2023, 4:05 PM

reading this stackoverflow post: https://stackoverflow.com/questions/60312156/how-to-use-protobuf-message-as-java-class-without-a-java-outer-class

Joey

02/15/2023, 4:10 PM

I think a breaking change is okay, so long as it is a significant improvement

yetitwo

02/15/2023, 5:01 PM

i'll open an issue and see if i can carve out time to get to it

Joey

02/15/2023, 5:05 PM

thanks!

yetitwo

02/15/2023, 5:46 PM

https://github.com/authzed/spicedb/issues/1170

yetitwo

02/15/2023, 7:34 PM

i have a changeset to

spicedb/api

that i think will work. how would i test building

authzed-java

locally against those proto files?

Joey

02/15/2023, 8:08 PM

@Sam ^

Sam

02/15/2023, 8:16 PM

A quick way would be to edit this in the build.gradle file to point to a local directory with the protos

Sam

02/15/2023, 8:16 PM

https://github.com/authzed/authzed-java/blob/main/build.gradle#L109

Sam

02/15/2023, 8:21 PM

(Or if you have buf installed, just running the equivalent command with your local proto files)

yetitwo

02/15/2023, 9:09 PM

oh, i do have buf installed. how would i go about doing it that way? it's been a while since i've invoked it

Joey

02/15/2023, 9:12 PM

@Sam ^

yetitwo

02/15/2023, 9:16 PM

i tried

buf generate .

in the

spicedb/api

repo root, but it's saying there isn't a

buf.gen.yaml

so i can't do it

yetitwo

02/15/2023, 9:17 PM

buf build

doesn't seem to have much of an effect 🤔

yetitwo

02/15/2023, 9:37 PM

also hmm.

java_multiple_files

doesn't seem to get rid of `OuterClass`es, and I can't for the life of me find any documentation on when `OuterClass`es will be generated. it seems to happen in the cases where there's a single RPC defined for a service and not when there are multiple RPCs, but I don't know why that would be.

yetitwo

02/15/2023, 9:41 PM

also what the hell is the protobuf versioning system? why are there v4 releases, v3 releases, and v22 releases all interleaved? is there an explanation of that somewhere?

yetitwo

02/15/2023, 9:55 PM

yeah i'm having a lot of "wat" right now. I opened an issue on the protobuf repo, and hopefully they can shed some light: https://github.com/protocolbuffers/protobuf/issues/11961

Joey

02/15/2023, 9:55 PM

protoc can be weird for Java

2 Views

Previous Next